fix(core/select): add vertical margin to filter chips (#474)

siemens · Apr 4, 2023 · 75b7180 · 75b7180
1 parent 795d326
commit 75b7180
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 15 deletions.
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "push-git": "node ./scripts/push-git.js",
     "sonarqube": "sonar-scanner",
     "visual-regression-ci": "npx playwright install chromium && yarn workspace @siemens/ix test:e2e && yarn workspace @siemens/ix-aggrid test:e2e",
-    "visual-regression": "docker run --rm --network host -v $(pwd):/work/ -w /work mcr.microsoft.com/playwright:v1.24.0-focal /bin/bash -c \"CI=TRUE npm run visual-regression-ci\"",
+    "visual-regression": "docker run --rm --network host -v $(pwd):/work/ -w /work mcr.microsoft.com/playwright:v1.32.1-focal /bin/bash -c \"CI=TRUE npm run visual-regression-ci\"",
     "test": "turbo run test",
     "prepare": "husky install"
   },

diff --git a/packages/aggrid/package.json b/packages/aggrid/package.json
@@ -41,7 +41,7 @@
     "ag-grid-community": "29.1.0",
     "@siemens/ix": "~1.5.0-beta.1",
     "@stencil/sass": "~3.0.0",
-    "@playwright/test": "^1.24.1",
+    "@playwright/test": "^1.32.1",
     "http-server": "^14.1.1"
   },
   "peerDependencies": {

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -36,7 +36,7 @@
     "test:coverage": "stencil test --spec --coverage",
     "test:e2e": "playwright test --reporter html",
     "test:e2e:list": "playwright test --reporter list",
-    "playwright.docker": "docker run --rm --network host -v $(pwd):/work/ -w /work/packages/core -it mcr.microsoft.com/playwright:v1.24.0-focal /bin/bash",
+    "playwright.docker": "docker run --rm --network host -v $(pwd):/work/ -w /work/packages/core -it mcr.microsoft.com/playwright:v1.32.1-focal /bin/bash",
     "host-root": "http-server ./ -a 127.0.0.1 -p 8080 -c-1",
     "generate": "stencil generate",
     "generate:theme": "ts-node -P ./scripts/generate-theme/tsconfig.json ./scripts/generate-theme/generate-theme"
@@ -50,7 +50,7 @@
     "@types/luxon": "^3.0.0"
   },
   "devDependencies": {
-    "@playwright/test": "^1.24.1",
+    "@playwright/test": "^1.32.1",
     "@siemens/ix-icons": "~1.0.0",
     "@stencil/vue-output-target": "^0.7.0",
     "@stencil-community/eslint-plugin": "^0.5.0",

diff --git a/packages/core/src/components/select/select.scss b/packages/core/src/components/select/select.scss
@@ -70,7 +70,7 @@
       overflow-y: auto;
 
       > ix-filter-chip {
-        margin: 0 0.1rem;
+        margin: 0.1rem;
       }
     }
 

diff --git a/packages/core/src/tests/select/select.e2e.ts b/packages/core/src/tests/select/select.e2e.ts
@@ -50,12 +50,19 @@ regressionTest.describe('select', () => {
 
     const inputHandle = await page.waitForSelector('div.chips');
 
+    await page.type(
+      '[data-testid="input"]',
+      'Lorem ipsum dolor sit amet, consectetur adipiscing elit.'
+    );
+
     page.evaluate((menuElement) => {
       menuElement.scrollTop = 9999;
       menuElement.classList.add('__SCROLLED__');
     }, inputHandle);
 
     await page.waitForSelector('div.chips.__SCROLLED__');
+    await page.locator('[data-testid="input"]').blur();
+    await page.waitForTimeout(500);
 
     expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
   });

diff --git a/...ct-mode-multiple-overflow-scroll-down-1-chromium---theme-classic-dark-linux.png b/...ct-mode-multiple-overflow-scroll-down-1-chromium---theme-classic-dark-linux.png
diff --git a/...t-mode-multiple-overflow-scroll-down-1-chromium---theme-classic-light-linux.png b/...t-mode-multiple-overflow-scroll-down-1-chromium---theme-classic-light-linux.png
diff --git a/yarn.lock b/yarn.lock
@@ -3271,13 +3271,15 @@
     os-homedir "^1.0.1"
     regexpu-core "^4.5.4"
 
-"@playwright/test@^1.24.1":
-  version "1.26.1"
-  resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.26.1.tgz#73ada4e70f618bca69ba7509c4ba65b5a41c4b10"
-  integrity sha512-bNxyZASVt2adSZ9gbD7NCydzcb5JaI0OR9hc7s+nmPeH604gwp0zp17NNpwXY4c8nvuBGQQ9oGDx72LE+cUWvw==
+"@playwright/test@^1.32.1":
+  version "1.32.1"
+  resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.32.1.tgz#749c9791adb048c266277a39ba0f7e33fe593ffe"
+  integrity sha512-FTwjCuhlm1qHUGf4hWjfr64UMJD/z0hXYbk+O387Ioe6WdyZQ+0TBDAc6P+pHjx2xCv1VYNgrKbYrNixFWy4Dg==
   dependencies:
     "@types/node" "*"
-    playwright-core "1.26.1"
+    playwright-core "1.32.1"
+  optionalDependencies:
+    fsevents "2.3.2"
 
 "@polka/url@^1.0.0-next.20":
   version "1.0.0-next.21"
@@ -8687,7 +8689,7 @@ fs.realpath@^1.0.0:
   resolved "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f"
   integrity sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==
 
-fsevents@^2.3.2, fsevents@~2.3.2:
+fsevents@2.3.2, fsevents@^2.3.2, fsevents@~2.3.2:
   version "2.3.2"
   resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.3.2.tgz#8a526f78b8fdf4623b709e0b975c52c24c02fd1a"
   integrity sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==
@@ -13031,10 +13033,10 @@ pkg-up@^3.1.0:
   dependencies:
     find-up "^3.0.0"
 
-playwright-core@1.26.1:
-  version "1.26.1"
-  resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.26.1.tgz#a162f476488312dcf12638d97685144de6ada512"
-  integrity sha512-hzFchhhxnEiPc4qVPs9q2ZR+5eKNifY2hQDHtg1HnTTUuphYCBP8ZRb2si+B1TR7BHirgXaPi48LIye5SgrLAA==
+playwright-core@1.32.1:
+  version "1.32.1"
+  resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.32.1.tgz#5a10c32403323b07d75ea428ebeed866a80b76a1"
+  integrity sha512-KZYUQC10mXD2Am1rGlidaalNGYk3LU1vZqqNk0gT4XPty1jOqgup8KDP8l2CUlqoNKhXM5IfGjWgW37xvGllBA==
 
 portfinder@^1.0.28:
   version "1.0.32"