Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/grid): add grid component #721

Merged
merged 16 commits into from
Sep 4, 2023
Merged

feat(core/grid): add grid component #721

merged 16 commits into from
Sep 4, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added this to the 2.0.0 milestone Aug 23, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Aug 23, 2023
@danielleroux danielleroux marked this pull request as ready for review August 25, 2023 10:15
packages/core/src/components/grid/grid.tsx Outdated Show resolved Hide resolved
packages/core/src/components/menu/menu.tsx Outdated Show resolved Hide resolved
packages/core/src/components/menu/menu.tsx Outdated Show resolved Hide resolved
packages/core/src/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark - sorry :)

packages/core/src/components/grid/grid.tsx Outdated Show resolved Hide resolved
danielleroux and others added 2 commits September 4, 2023 10:57
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit d82ef06 into main Sep 4, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/grid-layout branch September 4, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants