Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/tooltip): styles bleeding in #1444

Merged
merged 10 commits into from
Sep 4, 2024
Merged

fix(core/tooltip): styles bleeding in #1444

merged 10 commits into from
Sep 4, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Aug 30, 2024

💡 What is the current behavior?

  • styling from parents are bleeding into the tooltip

GitHub Issue Number: Closes #1061, [IX-901]

🆕 What is the new behavior?

  • new container that prevents styles from getting oberwritten

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 77a5a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft August 30, 2024 06:50
Copy link
Contributor

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

Total errors are the same in both branches

ESLint check

Total ESLint warnings are the same in both branches

@matthiashader matthiashader changed the title fix(core/tooltip): bg gets overwritten by table fix(core/tooltip): background gets overwritten by table Sep 3, 2024
@matthiashader matthiashader marked this pull request as ready for review September 4, 2024 05:02
@matthiashader matthiashader changed the title fix(core/tooltip): background gets overwritten by table fix(core/tooltip): styles bleeding in Sep 4, 2024
@danielleroux danielleroux merged commit 5acd52a into main Sep 4, 2024
16 checks passed
@danielleroux danielleroux deleted the fix/901-tooltip branch September 4, 2024 08:01
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parent element style leaks into ix-tooltip
2 participants