Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/menu-item): adjust bottom background color #420

Merged
merged 6 commits into from
Mar 13, 2023
Merged

fix(core/menu-item): adjust bottom background color #420

merged 6 commits into from
Mar 13, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #363

What is the new behavior?

  • Removed accent color line when selected
  • Changed background color when selected
  • Changed hover/active background color when selected

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested locally

Other information

@goncalosard goncalosard linked an issue Mar 2, 2023 that may be closed by this pull request
Navigation menu item: Colors for top and bottom items not as designed #363
Closed
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 3, 2023
@danielleroux danielleroux changed the title Fix(core/navigation item color): accent color line and hover/active background color fix(core/navigation item color): accent color line and hover/active background color Mar 9, 2023
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 9, 2023
@danielleroux danielleroux changed the title fix(core/navigation item color): accent color line and hover/active background color fix(core/menu-item): adjust bottom background color Mar 9, 2023
@danielleroux danielleroux merged commit f1f243c into main Mar 13, 2023
@danielleroux danielleroux deleted the fix/navigation-item-color branch March 13, 2023 11:06
@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.2 Mar 20, 2023
danielleroux pushed a commit that referenced this pull request Mar 20, 2023
@goncalosard @danielleroux
fix(core/menu-item): adjust bottom background color (#420)
9f23265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington Awaiting requested review from nuke-ellington

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

Navigation menu item: Colors for top and bottom items not as designed
2 participants
@goncalosard @danielleroux