Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stencil to v3.0.0 #431

Merged
merged 7 commits into from
Mar 7, 2023
Merged

chore: update stencil to v3.0.0 #431

merged 7 commits into from
Mar 7, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Mar 7, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Update to stencil v3

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 7, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 7, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 5cd04dc into main Mar 7, 2023
@danielleroux danielleroux deleted the update-stencil-v3 branch March 7, 2023 14:28
@danielleroux danielleroux linked an issue Mar 7, 2023 that may be closed by this pull request
4 tasks
@danielleroux danielleroux added pull request affects minor version The pull request affects only minor version and removed pull request affects patch version The pull request affects only patch version labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to @stencil/core@3.0.0
2 participants