fix(core/modal): fixes runtime error

[matthiashader]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (yarn build) was run locally and any changes were pushed
• Unit tests (yarn test) were run locally and passed
• Visual Regression Tests (yarn visual-regression) were run locally and passed
• Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bug fix
• Feature
• Refactoring (no functional changes, no API changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

• In the preview example a runtime error occurs on react

GitHub Issue Number: #900

What is the new behavior?

• no runtime error on the preview example

Does this introduce a breaking change?

• Yes
• No

Testing

Other information

[EnesKilicaslan]

Hi @matthiashader , thanks for the implementation.
However, I wonder how this will resolve the problem. The issue appears even I close the modal with cancel button.

[matthiashader]

Hi @matthiashader , thanks for the implementation. However, I wonder how this will resolve the problem. The issue appears even I close the modal with cancel button.

@EnesKilicaslan
Even if you remove the onCloseClick in the IxModalHeader? Like:


Message headline

The error from my perspective was related to the fact that the modal-header and the also the event handling took care of closing the modal, so one of these didnt find it the before closed modal.

[EnesKilicaslan]

I see
At first, I thought it can not be related with header because I never close the modal from the header, instead I use cancel button.
However, it might not be like that.
All, I can say is it does not completely fix it.

[danielleroux]

I see At first, I thought it can not be related with header because I never close the modal from the header, instead I use cancel button. However, it might not be like that. All, I can say is it does not completely fix it.

What do you exactly mean?

[nuke-ellington]

JSDocs changes

[EnesKilicaslan]

I see At first, I thought it can not be related with header because I never close the modal from the header, instead I use cancel button. However, it might not be like that. All, I can say is it does not completely fix it.

What do you exactly mean?

I mean, just removing onCloseClick from ModalHeader does not solve the problem

[matthiashader]

I see At first, I thought it can not be related with header because I never close the modal from the header, instead I use cancel button. However, it might not be like that. All, I can say is it does not completely fix it.

What do you exactly mean?

I mean, just removing onCloseClick from ModalHeader does not solve the problem

Could you then provide us with a snippet where the error still remains? Because i can't produce any runtime error without the onCloseClick

[nuke-ellington]

Minor change

stale