You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Do you think it makes sense to have support for sisl types in the SiestaBaseWorkchain?
Using a very simple serializer for the inputs:
defsisl_serializer(sisl_obj):
''' Function that converts sisl objects to aiida types. '''try:
importsislexceptModuleNotFoundError:
returnifisinstance(sisl_obj, sisl.Geometry):
returnStructureData(ase=sisl_obj.toASE())
elifisinstance(sisl_obj, sisl.MonkhorstPack):
kpoints=KpointsData()
kpoints.set_kpoints_mesh(sisl_obj._diag, sisl_obj._displ)
returnkpoints
then you could directly pass geometries from sisl as inputs for an aiida workflow, which I believe it's interesting because sisl can read structures from *fdf, *XV, etc... and this would probably reduce the friction between siesta users and aiida.
Or maybe it's not worth it because the user may be creating multiple nodes with the same structure without knowing it?
The text was updated successfully, but these errors were encountered:
Hi! Do you think it makes sense to have support for sisl types in the
SiestaBaseWorkchain
?Using a very simple serializer for the inputs:
then you could directly pass geometries from sisl as inputs for an aiida workflow, which I believe it's interesting because sisl can read structures from *fdf, *XV, etc... and this would probably reduce the friction between siesta users and aiida.
Or maybe it's not worth it because the user may be creating multiple nodes with the same structure without knowing it?
The text was updated successfully, but these errors were encountered: