Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split project into multiple crates #34

Open
ppoliani opened this issue Feb 4, 2024 · 4 comments
Open

Split project into multiple crates #34

ppoliani opened this issue Feb 4, 2024 · 4 comments

Comments

@ppoliani
Copy link
Contributor

ppoliani commented Feb 4, 2024

We've had this discussion here already #24. With the addition of version checks I realized that it makes sense to split the crates for the purpose of proper versioning.

Changes to the admin cli are independent from the user cli tool. Thus we would need to keep different versions and having a single crate does not help.

@ppoliani
Copy link
Contributor Author

@mimoo do you think we can re-open #24?

@mimoo
Copy link
Contributor

mimoo commented Feb 16, 2024

I think before that would happen we would need to move the code that's in the CLI to the internal functions (I haven't had the time to clean up the code I added within the CLI commands that really don't belong there :D)

if you're interested in tackling this feel free to push a PR! Otherwise I'll try to find some time this week end

@ppoliani
Copy link
Contributor Author

I just checked the commits. I believe you've done some work around this, right?

@mimoo
Copy link
Contributor

mimoo commented Feb 23, 2024

we discussed with @imikushin and agreed to postpone this as it's not urgent work, but I agree that we should tackle this at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants