-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Backups are inflated in size #11509
Comments
Replying to a message of a large file/media has the same effect. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This is reproducable with the current Signal version Thanks for trying though, stale bot. /s |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is reproducable with the current Signal version |
This issue has been closed due to inactivity. |
i guess it could be argued that this should not be discussed as a github issue as per this rule from #7598
i would disagree because issues like this are part of the reason signal backups are much larger than necessary. as a result, i do not create any signal backups because i don't have the storage on my phone to store them. in my experience, this is equivalent to a feature that is not working; i am unable to create any signal backups at all even though i have enough storage on my PC. Signal does not offer any way to create useful backups on external / could storage unless you have lots of excess storage on your phone and copy huge monolithic backups every day. i have no hope that this set of issues will ever be resolved (given its history of only making baby steps every now and then over multiple years). here's some relevant forum threads that i could find for anyone else reading this issue: |
Hey there, we have an idea as to why this is happening, and tracking internally to fix. |
Thanks a lot for acknowledging the issue! |
My comment from #12106:
|
As a workaround, I have to go to the Settings / Data and storage / Manage storage and delete large duplicate files manually about once a month (I forward a lot of photos to a lot of people). An expiry on large files would also help with this issue. Currently, I can expire only messages, which take almost no space if without attachments. |
I read somewhere that when you reply to a message with a media, the media gets duplicated and gets included to the backup. Even after deleting the original media, the backup size remains largely unaffected. I am guessing the duplicated media doesn't get deleted and I don't see any other way to get rid of that media since it doesn't show up under Storage usage. My backup size currently stands at twice of the Storage as shown by Signal. I have consciously avoiding replying to any media but it is a huge inconvenience. Would be happy if this gets looked into. Or at the very least, it would be convenient to be able to see the media and delete manually. |
I can confirm this. When I cleaning up my storage when reached 1.5 GB. I had to manually scroll and delete replied messages from chats. That reduced about 900 MB. And actual media was taking up ~450 MB. So, this seems like a big issue since replied chats take more space compared to actual media, specially in group chats
You can by deleting the specific reply, but it can be a pain to find |
On my phone, Signal says it occupies 9.7 GB, Android says it occupies 10.2 GB. So that is more or less consistent. But the backup takes 26.3 GB. 🤬 |
Hey folks, if you've looked at our recent commit history you can see we've been building out a new backup system. Part of that work addresses the inflated size by only writing out one local copy of the file. |
Bug description
When creating backups using the "Chat backups" feature the resulting backup files don't appear to be deduplicated. They can be vastly bigger than the actual data used by the Signal app. Forwarding messages inflates backup size while Signal App Data Size does not change.
Steps to reproduce
Actual result: The Backup file size increases by the size of the forwarded file while Signal App usage does not. For example, in the case of another persons Signal i observed 400MB of app data usage while the backup file size was about 1GB.
Expected result: If Signal deduplicates forwarded messages internally they should also be deduplicated in backup files. The backup file should not be considerably larger than Signals app data.
Device info
Device: Xiaomi Redmi 4X
Android version: LineageOS 15.1 based on AOSP 8.1.0
Signal version: 5.18.5
Link to debug log
https://debuglogs.org/bb268c5fb8102c6c3430235813b64721c100dec8c3ac8dfe71885073a2133fc1
The text was updated successfully, but these errors were encountered: