Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending SMS via Google Now voice comand bypasses TextSecure #218

Closed
tin-can-zz opened this issue Jun 26, 2013 · 16 comments
Closed

Sending SMS via Google Now voice comand bypasses TextSecure #218

tin-can-zz opened this issue Jun 26, 2013 · 16 comments

Comments

@tin-can-zz
Copy link

I like being able to send SMS messages via the Google Now voice option on my Galaxy S3; however, when I do this, the messaging app that came with the S3 is being used to send the messages instead of TextSecure.

At first I thought this was because TextSecure was locked, but after entering the passphrase and leaving TextSecure unlocked, it still does not work with Google Now.

@mcginty
Copy link
Contributor

mcginty commented Feb 6, 2014

Hmm, when I say "send a text message to Contact Name" it seems to open the TextSecure conversation for them. Is this still an issue, or am I not reproducing this correctly?

@ellotheth
Copy link

The problem occurs when you do the full message via voice commands:

send a text message to Contact Name this is my message

Google Now will compose and send the whole message for you without any physical interaction, but it doesn't use TextSecure.

@rimmington
Copy link

I can confirm this issue on the Galaxy S5. Oddly, after sending a message via Now, an "Open in TextSecure" shortcut is displayed below the message despite the fact that the message is not sent with TextSecure but instead with the default Messaging app.

@mcginty mcginty added bug and removed bug labels May 10, 2014
@rhodey
Copy link
Contributor

rhodey commented Mar 25, 2015

OK Google, send a text message to <contact name> on my Nexus 5 running stock Android Lollipop 5.1 brings up what appears to be the quick compose dialog of the default Messenger app. I wonder if TextSecure will show up when we add support for quick compose?

@anisse
Copy link

anisse commented Apr 29, 2015

Just to add some details: a voice command (android wear/google voice commands/now…) will write a message in the SMS database (readable in hangouts for example), but TextSecure doesn't seem to watch the sms database for new messages, or use it at all (there should be an option to export "unsafe" messages to the SMS database when you switch away from textsecure).

@maxauvy
Copy link

maxauvy commented May 5, 2015

I can confirm this behavior, it was already the case with Android 5.0.2 and Android Wear 5.0.2. If I launch a vocal command to the phone or to the watch, SMS will be sent unencrypted via the default SMS App, even if there's a secured conversation available in TextSecure. Still valid with Android 5.1.1 (CM12.1 in my case).

And yes, TextSecure doesn't "see" this SMS, but you can still import it from the system DB via the import/export submenu!

Also @anisse you can do a "plain text export" with TextSecure and import it to the system database with an app like SMS Backup and Restore, if needed ;)

@anisse
Copy link

anisse commented May 5, 2015

@maxauvy : I'm not sure using another app to do the job counts as a feature; it's also awful UX, making it hard to move away from TS; but that's the subject for another bug.

The problem is that you can't use the import submenu to just stay sync: there will just be duplicate messages, as stated in the warning box.
Also, you shouldn't have to keep importing messages just because some other app sent an sms (in this case the Wear/Google app); those messages should automatically appear in the correct conversation so you follow when people answer you.

@joepetrakovich
Copy link

@maxauvy this issue occurs even if TextSecure is the default SMS app. I can confirm this behavior on a Nexus 6P.

@vinilox
Copy link

vinilox commented Nov 21, 2015

Everybody are suggesting that a "android sms DB watcher" is implemented to automatically import new sms send via third party apps like Google now. Right ?
Is this possible to do @mcginty @moxie0 ?
Thanks for your answer. :)

@castanley
Copy link

I too am having this issue. Would love this to be resolved!

@pjedge
Copy link

pjedge commented Feb 27, 2016

http://venturebeat.com/2015/07/28/android-users-can-now-say-ok-google-to-send-messages-via-whatsapp-wechat-nextplus-telegram-and-viber/

It appears that apps such as telegram, whatsapp, and more now support sending via Google now. Would it be hard to implement the same -- "okay google, send a signal message to XXXXX?"

@cascheberg
Copy link
Contributor

@pjedge From reading the article that you linked I understand that the feature requires support by Google for each app. So it cannot be implemented in Signal without Googles support.

@gooddadmike
Copy link

So what does it take to get Googles Support?

@joeykrim
Copy link
Contributor

joeykrim commented May 4, 2017

The last question seems to be whether it's possible to have voice interactions exposed to an application without Google's explicit support.
On a Google Pixel XL (Android 7.1.1), the voice command "Send a text message" defaults to the Android Messenger application and ignores Signal, even when Signal is marked as the default application. In addition, "Sent a text message with WhatsApp" works and opens WhatsApp, but "Sent a text message with Signal" results in a web search.

Google has listed some voice interactions that are available, but they don't explicitly list sending a text message/SMS, as a possible voice interaction: https://developers.google.com/voice-actions/system/.

After quickly going through their Codelab tutorial (http://io2015codelabs.appspot.com/codelabs/voice-interaction#1), I don't see how to bind to the initial and specific voice command "Send a text message". The codelab example does show how to handle the intent(responding via voice and confirming action completed) after Google passes the intent to the application from the voice command.

For custom voice actions, it seems Google isn't accepting suggestions anymore, "Note: We are not accepting requests for Custom Voice Actions. Stay tuned to Voice Actions - Google Developers and +GoogleDevelopers for product updates.": https://developers.google.com/voice-actions/custom-actions

@JSzaszvari
Copy link

With the newly released google assistant SDK this should be possible now. Something like " send a signal to bob saying I'll be home in 5 mins"

@automated-signal
Copy link

GitHub Issue Cleanup:
See #7598 for more information.

@signalapp signalapp locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests