build/dns-fallback.json should be provided in source code

[brjsp]

Using a supported version?

• I have searched searched open and closed issues for duplicates.
• I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

Many downstream redistributors such as Linux distros have a requirement that the entire source code of the software is available — to enforce this, the code, including all dependencies, is packed first, and then compiled on a machine without network access.

Since version 7.1.0 (commit e3dbcc1) the Signal build process tries to download things from the internet.

We could run ts/scripts/generate-dns-fallback.ts` in our tarball download script, but we'd rather not, as it downloads things from an untrusted source (the user's ISP) and stores them without any verification.

We have for now resorted to using the version of generate-dns-fallback.ts that is provided in the .deb packages in your repository.

Steps to reproduce

1. Unpack the signal tarball from github
2. Download the node dependencies and build them (a rough equivalent of yarn install)
3. Disconnect the internet
4. yarn generate

Expected result

Build succeeds

Actual result

The build:dns-fallback step fails

Screenshots

No response

Signal version

7.1.1

Operating system

openSUSE Tumbleweed

Version of Signal on your phone

No response

Link to debug log

No response

[indutny-signal]

This is an optional file that is only useful for situations where DNS resolver is not available. It is safe to either put an empty JSON array there, or omit the file entirely.

Sorry for the inconvenience!