Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Error: expression evaluated to a falsy value #6978

Closed
2 tasks done
tqwewe opened this issue Aug 13, 2024 · 11 comments
Closed
2 tasks done

Unhandled Error: expression evaluated to a falsy value #6978

tqwewe opened this issue Aug 13, 2024 · 11 comments

Comments

@tqwewe
Copy link

tqwewe commented Aug 13, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

Whilst sending photos on Signal on my phone, I received an unexpected error on Signal running on my Macbook.

Steps to reproduce

I'm not sure how to reproduce it exactly, but I was sending batches of photos on my phone, and had Signal open on my macbook at the same time with that chat open. I had to retry a batch of photos if that provides any useful context.

Expected result

No error should occur.

Actual result

Unhandled Error

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, node_assert_1.default)(entry)

    at DefaultStorage.cleanup ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:118:35)
    at DefaultStorage.put ([REDACTED]/node_modules/@indutny/range-finder/dist/src/default-storage.js:92:14)
    at SkipTransform.<anonymous> ([REDACTED]/node_modules/@indutny/range-finder/dist/src/index.js:94:26)
    at Object.onceWrapper (node:events:633:28)
    at SkipTransform.emit (node:events:519:28)
    at SkipTransform._destroy ([REDACTED]/node_modules/@indutny/range-finder/dist/src/skip-transform.js:29:14)
    at _destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:92:10)
    at SkipTransform.destroy ([REDACTED]/node_modules/@indutny/range-finder/node_modules/readable-stream/lib/internal/streams/destroy.js:62:5)
    at Object.cancel ([REDACTED]/ts/util/toWebStream.js:54:16)
    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2390:39)

Screenshots

No response

Signal version

7.19.1 production (Intel)

Operating system

macOS 10.15.7

Version of Signal on your phone

7.13.3 (Android)

Link to debug log

No response

@nem64
Copy link

nem64 commented Aug 13, 2024

I can confirm this. Latest Signal Desktop crashes for me with the same error message and same steps to reproduce. Running the Flatpak version on Linux. Reverting the version back to commit b6aafea3dc60b68b891e2efd60dee33ea7740d172f7abde0e68e0acea339d264* fixes the issue. However it's not a real fix as I'm running an outdated version now.

* The commit version on the Flatpak tree, not the git tree

@indutny-signal
Copy link
Contributor

Sorry about this. I identified one more issue in that upstream dependencies and this going to be fixed in the next release (coming soon).

@mikesimone
Copy link

I'm getting this on Signal Desktop for Windows, and I don't even have to be doing anything. Just letting it run.

Unhandled Error

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, node_assert_1.default)(entry)

    at DefaultStorage.cleanup ([REDACTED]\node_modules\@indutny\range-finder\dist\src\default-storage.js:120:35)
    at DefaultStorage.put ([REDACTED]\node_modules\@indutny\range-finder\dist\src\default-storage.js:92:14)
    at SkipTransform.<anonymous> ([REDACTED]\node_modules\@indutny\range-finder\dist\src\index.js:94:26)
    at Object.onceWrapper (node:events:633:28)
    at SkipTransform.emit (node:events:519:28)
    at SkipTransform._destroy ([REDACTED]\node_modules\@indutny\range-finder\dist\src\skip-transform.js:29:14)
    at _destroy ([REDACTED]\node_modules\@indutny\range-finder\node_modules\readable-stream\lib\internal\streams\destroy.js:92:10)
    at SkipTransform.destroy ([REDACTED]\node_modules\@indutny\range-finder\node_modules\readable-stream\lib\internal\streams\destroy.js:62:5)
    at Object.cancel ([REDACTED]\ts\util\toWebStream.js:54:16)
    at readableStreamDefaultControllerCancelSteps (node:internal/webstreams/readablestream:2390:39)

@indutny-signal
Copy link
Contributor

indutny-signal commented Aug 15, 2024

@mikesimone sorry about this, could you try updating to 7.20.0?

@mikesimone
Copy link

@mikesimone sorry about this, could you try updating to 7.20.0?

LOL. Literally two seconds after your message popped up, it showed that there was an update ready, and so I just installed it. I'll let it run for a few hours, and see if that stopped the error from popping up.

Thank you!

@sietseringers
Copy link

I get the same exception with an identical stack change (only differing line numbers; I'm on 7.20.0) when I go to a chat, click on a picture, and then keep the left button on my keyboard pressed to quickly navigate back to previous photo's. The application then crashes with this stack change after quickly showing perhaps some 50 photo's.

@indutny-signal
Copy link
Contributor

@sietseringers sorry about this! could you send a debug log, please?

@sietseringers
Copy link

Not to worry, it isn't much of a problem to me 🙂

Here is the debug log: https://debuglogs.org/desktop/7.20.0/b8baae462bc4495a122c66ea3f514a88451924a81f1b3d494c7e0989cc98f2ba.gz

@indutny-signal
Copy link
Contributor

Thank you! We'll fix it in the next release!

@indutny-signal
Copy link
Contributor

Could you give a try to 7.20.1 to see if it is any better, please? Thank you ❤️

@sietseringers
Copy link

Looks like it's fixed, can't reproduce it anymore. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants