From 86d99817c99846ebe65573175edb433d808116d2 Mon Sep 17 00:00:00 2001
From: Nuno Polonia <nunopolonia@gmail.com>
Date: Fri, 15 Dec 2023 17:00:17 +0000
Subject: [PATCH 1/3] fix: tag former team members as such in blog

Fixes SIGN-584

- Add (former) to person component
- Pass is_active to person as prop in blog-entry
- Pass is_active to person as prop in blog-post
---
 src/components/blog-entry.svelte      | 1 +
 src/components/pages/blog-post.svelte | 7 ++++++-
 src/components/person.svelte          | 4 +++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/components/blog-entry.svelte b/src/components/blog-entry.svelte
index 99439614..5a0e37cd 100644
--- a/src/components/blog-entry.svelte
+++ b/src/components/blog-entry.svelte
@@ -22,6 +22,7 @@
   <div class="container mx-auto flex gap-6 px-container py-8 @container">
     <div class="hidden flex-1 @6xl:block">
       <Person
+        is_active={post.content.author.content.is_active}
         name={post.content.author.name}
         position={post.content.author.content.position}
         photo={post.content.author.content?.photo}
diff --git a/src/components/pages/blog-post.svelte b/src/components/pages/blog-post.svelte
index 274bc648..8f8d8d11 100644
--- a/src/components/pages/blog-post.svelte
+++ b/src/components/pages/blog-post.svelte
@@ -75,7 +75,12 @@
   {#if story.content.author?.id}
     {@const author = story.content.author}
     <div use:drawerLinks class="mx-auto mt-10 max-w-2xl border-b border-t py-8 md:mt-14 lg:mt-20">
-      <Person name={author.name} position={author.content.position} photo={author.content.photo} />
+      <Person
+        is_active={author.content.is_active}
+        name={author.name}
+        position={author.content.position}
+        photo={author.content.photo}
+      />
       <p class="mt-6 text-xl text-foreground-secondary">{author.content.bio}</p>
       <Button
         variant="secondary"
diff --git a/src/components/person.svelte b/src/components/person.svelte
index 8975c88e..13cf56bb 100644
--- a/src/components/person.svelte
+++ b/src/components/person.svelte
@@ -1,4 +1,5 @@
 <script lang="ts">
+  import { t } from '$lib/i18n';
   import { getImageAttributes } from '$lib/utils/cms';
   import type { AssetStoryblok } from '$types/bloks';
   import { Avatar } from '@significa/svelte-ui';
@@ -7,6 +8,7 @@
   let className: string | undefined = undefined;
   export { className as class };
 
+  export let is_active: boolean | undefined = undefined;
   export let name: string;
   export let position: string | undefined = undefined;
   export let photo: AssetStoryblok | undefined = undefined;
@@ -24,7 +26,7 @@
     {/if}
     {#if position}
       <p class="mt-1 text-base font-semibold leading-none text-foreground-secondary">
-        {position}
+        {!is_active ? `${t('team.former')} ` : ''}{position}
       </p>
     {/if}
   </div>

From 1bd791d1be874559bf5b8b44a486940a78fb6086 Mon Sep 17 00:00:00 2001
From: Nuno Polonia <nunopolonia@gmail.com>
Date: Mon, 18 Dec 2023 12:30:12 +0000
Subject: [PATCH 2/3] fix: change is_active variable to camelCase

---
 src/components/blog-entry.svelte      | 2 +-
 src/components/pages/blog-post.svelte | 2 +-
 src/components/person.svelte          | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/blog-entry.svelte b/src/components/blog-entry.svelte
index 5a0e37cd..4b82b815 100644
--- a/src/components/blog-entry.svelte
+++ b/src/components/blog-entry.svelte
@@ -22,7 +22,7 @@
   <div class="container mx-auto flex gap-6 px-container py-8 @container">
     <div class="hidden flex-1 @6xl:block">
       <Person
-        is_active={post.content.author.content.is_active}
+        isActive={post.content.author.content.is_active}
         name={post.content.author.name}
         position={post.content.author.content.position}
         photo={post.content.author.content?.photo}
diff --git a/src/components/pages/blog-post.svelte b/src/components/pages/blog-post.svelte
index 8f8d8d11..01d01fb8 100644
--- a/src/components/pages/blog-post.svelte
+++ b/src/components/pages/blog-post.svelte
@@ -76,7 +76,7 @@
     {@const author = story.content.author}
     <div use:drawerLinks class="mx-auto mt-10 max-w-2xl border-b border-t py-8 md:mt-14 lg:mt-20">
       <Person
-        is_active={author.content.is_active}
+        isActive={author.content.is_active}
         name={author.name}
         position={author.content.position}
         photo={author.content.photo}
diff --git a/src/components/person.svelte b/src/components/person.svelte
index 13cf56bb..33591853 100644
--- a/src/components/person.svelte
+++ b/src/components/person.svelte
@@ -8,7 +8,7 @@
   let className: string | undefined = undefined;
   export { className as class };
 
-  export let is_active: boolean | undefined = undefined;
+  export let isActive: boolean | undefined = undefined;
   export let name: string;
   export let position: string | undefined = undefined;
   export let photo: AssetStoryblok | undefined = undefined;
@@ -26,7 +26,7 @@
     {/if}
     {#if position}
       <p class="mt-1 text-base font-semibold leading-none text-foreground-secondary">
-        {!is_active ? `${t('team.former')} ` : ''}{position}
+        {!isActive ? `${t('team.former')} ` : ''}{position}
       </p>
     {/if}
   </div>

From f265c18de7c7fe09d16ff96752bd8e035a7c7e60 Mon Sep 17 00:00:00 2001
From: Nuno Polonia <nunopolonia@gmail.com>
Date: Mon, 18 Dec 2023 12:31:15 +0000
Subject: [PATCH 3/3] fix: change isActive prop default in Person component

Since the Person component is also used in the Testimonials
which don't have an isActive prop, it needs to default to true otherwise
the (former) tag will be shown in the testimonials
---
 src/components/person.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/person.svelte b/src/components/person.svelte
index 33591853..48cd0b3d 100644
--- a/src/components/person.svelte
+++ b/src/components/person.svelte
@@ -8,7 +8,7 @@
   let className: string | undefined = undefined;
   export { className as class };
 
-  export let isActive: boolean | undefined = undefined;
+  export let isActive: boolean = true;
   export let name: string;
   export let position: string | undefined = undefined;
   export let photo: AssetStoryblok | undefined = undefined;