Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single lookups should consider processed/processing blocks/blobs #4667

Closed
realbigsean opened this issue Aug 25, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working deneb

Comments

@realbigsean
Copy link
Member

Description

Observing on devnet 8 that we are doing too many single block lookups, looking up blocks/blobs that we've already processed. This is because of a combination of the delayed lookup logic (which waits for a period of time to see whether we get all block components over gossip before triggering a request), and the fact that we're only checking the DataAvailabilityChecker for missing components, not considering currently processing or previously processed and imported blocks/blobs.

We are frequently:

  1. queuing a delayed lookup request
  2. then receiving all block components on gossip, meaning the delayed lookup request is no longer needed
  3. importing the block
  4. then dequeuing the delayed lookup, being unaware the blocks been fully imported

We should additionally consider blocks/blobs that we are processing but have not yet hit the DataAvailabilityChecker. Perhaps this be done with our gossip "seen" caches?

@realbigsean
Copy link
Member Author

resolved in #4732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deneb
Projects
None yet
Development

No branches or pull requests

1 participant