Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use validator/blocks v3 endpoint in the VC #4812

Closed
jimmygchen opened this issue Oct 6, 2023 · 2 comments · Fixed by #4813
Closed

Use validator/blocks v3 endpoint in the VC #4812

jimmygchen opened this issue Oct 6, 2023 · 2 comments · Fixed by #4813
Assignees
Labels
deneb val-client Relates to the validator client binary

Comments

@jimmygchen
Copy link
Member

jimmygchen commented Oct 6, 2023

Description

The validator/blocks v3 implementation is currently being worked on in #4629. Once that's ready we should switch the VC to use the v3 endpoint.

A few other clients are also in the process of implementing the endpoint, so we'd need to come up with a sensible upgrade strategy.

  • we probably want to ship this together with [Merged by Bors] - Block v3 endpoint #4629 and encourage user to update both Lighthouse BN and VC
  • if user uses a different CL client that does not support V3 yet, do we introduce a flag to allow user to override the behaviour?
    • @michaelsproul suggested that we could use it by default once Deneb is enabled (all clients would have it ready by then), or have a flag to enable it prior to Deneb, so like:
if deneb_already_happened || config.use_v3 {
   beacon_node.get_v3(..)
} else {
   beacon_node.get_v2(..)
}

Beacon API spec:

@jimmygchen jimmygchen added val-client Relates to the validator client binary deneb labels Oct 6, 2023
@eserilev
Copy link
Collaborator

eserilev commented Oct 6, 2023

i'd like to pick this one up

@jimmygchen jimmygchen linked a pull request Oct 9, 2023 that will close this issue
3 tasks
@jimmygchen
Copy link
Member Author

Completed in #4813 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb val-client Relates to the validator client binary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants