You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We used to use ?block_root to get the full block root via its Debug impl, and %block_root or just block_root to use the Display impl which was abbreviated. I think alloy must not be using the abbreviated format for Display, which is a reasonable design decision.
Description
With the switch to
alloy-primitives
in v6.0.0, we inadvertently changed the formatting ofHash256
values in the logs! Previously:Now, the full block roots are displayed:
We used to use
?block_root
to get the full block root via itsDebug
impl, and%block_root
or justblock_root
to use theDisplay
impl which was abbreviated. I think alloy must not be using the abbreviated format forDisplay
, which is a reasonable design decision.Version
Lighthouse v6.0.0, since:
ethereum-types
toalloy-primitives
#6078Steps to resolve
Alloy doesn't seem to provide a short format at all (looking at https://docs.rs/alloy-primitives/0.8.15/alloy_primitives/struct.FixedBytes.html). We would need to write one ourselves, possibly something zero-copy that integrates with our logging library.
Seeing as we're imminently switching to
tracing
, this issue should probably wait until the tracing PR is merged:The text was updated successfully, but these errors were encountered: