Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Remote Monitoring to Report Disk Usage for Datadir Mount Point #6687

Open
hqy2000 opened this issue Dec 12, 2024 · 2 comments · May be fixed by #6741
Open

Update Remote Monitoring to Report Disk Usage for Datadir Mount Point #6687

hqy2000 opened this issue Dec 12, 2024 · 2 comments · May be fixed by #6741
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does!

Comments

@hqy2000
Copy link

hqy2000 commented Dec 12, 2024

Description

In remote monitoring, Lighthouse Advanced Metrics reports disk stats, such as disk_node_bytes_free, for the disk mounted at /. However, this may not correspond to the disk holding the actual beacon chain data.

Version

Using the 6.0.0 executable from the release.

Present Behavior

Currently, remote monitoring always reports the disk space for the root (/) mount point.

Relevant code reference:

lighthouse/common/eth2/src/lighthouse.rs

Line 183 in c042dc1

let disk_usage = psutil::disk::disk_usage("/")

Expected Behavior

Remote monitoring should report the disk space for the datadir (or the default directory) instead of the root mount point. This is important as users may mount a separate drive specifically for beacon chain data.

Steps to Resolve

  1. Set up Lighthouse with remote monitoring enabled.
  2. Configure datadir to point to a mount point on a second drive intended for storing beacon chain data.
  3. Observe the reported disk stats to see if it's for the datadir mount point or /.
@dapplion dapplion added good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does! labels Dec 17, 2024
@takaebato
Copy link

I'll work on this!

@rose2221
Copy link

i'd like to work on this

@crStiv crStiv linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct datadir disk usage reporting in lighthouse.rs crStiv/lighthouse
4 participants
@hqy2000 @dapplion @takaebato @rose2221