Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Validator Client voluntary_exit endpoint response #217

Closed
jimmygchen opened this issue Aug 31, 2023 · 1 comment
Closed

Changes to Validator Client voluntary_exit endpoint response #217

jimmygchen opened this issue Aug 31, 2023 · 1 comment

Comments

@jimmygchen
Copy link
Member

There is a non-compliance on the voluntary_exit endpoint response with the key manager API spec, and is being addressed in Lighthouse sigp/lighthouse#4679 (still under review)

This is a small change to add a data layer to the response, but it's a breaking change for Siren and response type needs to be updated.

Existing response

{"message":{"epoch":"196868","validator_index":"505597"},"signature":"0xhexsig"}

New response:

{"data":{"message":{"epoch":"196868","validator_index":"505597"},"signature":"0xhexsig"}}

It might be worth supporting both response types in the UI for a little while so users aren't force to upgrade to the latest Lighthouse version.

@rickimoore
Copy link
Member

#220

addressed and merged in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants