Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return multiple rekor entries if looked up during verify-blob #1447

Closed
dlorenc opened this issue Feb 11, 2022 · 2 comments
Closed

Return multiple rekor entries if looked up during verify-blob #1447

dlorenc opened this issue Feb 11, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@dlorenc
Copy link
Member

dlorenc commented Feb 11, 2022

Description

In verify-blob with the transparency log enabled, we'll attempt to look up an entry in the log using the search API. This will return the latest signature/cert found for a blob, which may not be the one the user actually is looking for. We should consider improving this UX if multiple entries are found. The relevant codepath is here:

func FindTlogEntry(ctx context.Context, rekorClient *client.Rekor, b64Sig string, payload, pubKey []byte) (uuid string, index int64, err error) {

In general we'll also need to better explain the guarantees of the search API. The results returned from it are generally considered "best-effort" and are not guaranteed to be comprehensive. Every result in that API is valid - but the API does not necessarily return every result.

@znewman01
Copy link
Contributor

This behavior was fixed in #1673 .

We could still explain better what's going on; I'll send a quick PR for that.

@znewman01
Copy link
Contributor

Oh actually #1673 does add a message clarifying the guarantees. It does so only when relevant: that is, the search API didn't find a corresponding signature.

This can be closed.

@asraa asraa closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants