-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: Allow verifying CN when verifying using certificates #2279
Comments
Thanks for the details! This is definitely a case we should support. cc @znewman01 |
Interesting question! Supporting verification of fields that aren’t set by Fulcio sounds like out of scope for Cosign. Fulcio only sets SANs, not common name. I think this should be a part of a verification engine. @znewman01 has outlined a new command “inspect” that would support such requests for verification of other fields, by returning structured info about the certificate, signature, etc to the caller. If we do want to support verification of arbitrary X.509 fields, I think we are going to need to think through what that UX looks like. I’d rather not keep growing the list of certificate verification flags. |
@haydentherapper Would you be okay with allowing SANs instead of CN in that case to be verified in the |
Feature incoming! #1964 |
+1 to the @haydentherapper's general sentiment: I really would prefer to avoid giving This suggests to me the following conclusions:
@maxking: I'm glad that for your use case the SAN verification will work. Let's leave this issue open to track the general issue of enabling verification for hybrid use cases (BYO certs). |
Description
I have described how we are trying to use Cosign here, but in short, we provision identity certificates to all services and want to use those for signing and verification. So far, I've been able to sign using the cert and verify using kyverno (#1554: bug for verification usign cosign CLI).
Given that all certificates issued using the Root CA will be valid when verifying using the root CA, we want to limit the servicePrincipal/userPrincipals whose signatures are trusted. It is similar to what is described in the "Self-managed keys in identity-based code signing certificate with auditability" section in this blog post.
Currently,
cosign verify
command already has a bunch of--certitificate-*
attributes, presumably intending to verify different attributes about the identity when using OIDC token. But the ask here to extend that to allow verifyingCN
for self managed certificates. Although, it would be better to support fields underX509v3 Subject Alternative Name
as a more general verification.The text was updated successfully, but these errors were encountered: