Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Integrate some content of keyless.md into overview.md #155

Closed
jonvnadelberg opened this issue Apr 25, 2023 · 5 comments · Fixed by #156
Closed

docs: Integrate some content of keyless.md into overview.md #155

jonvnadelberg opened this issue Apr 25, 2023 · 5 comments · Fixed by #156
Assignees
Labels
enhancement New feature or request

Comments

@jonvnadelberg
Copy link
Collaborator

Description

some parts of keyless.md need to be integrated into the overview.md file as it now exists.

@jonvnadelberg jonvnadelberg added the enhancement New feature or request label Apr 25, 2023
@Bhardwaj-Himanshu
Copy link

Hi @jonvnadelberg,
Could you also point on the points or topics which need to be moved from one file to another?
Thanks!

@jonvnadelberg
Copy link
Collaborator Author

Chiefly the ttl.sh information that gives a good example of signing with containeres.

@Bhardwaj-Himanshu
Copy link

Bhardwaj-Himanshu commented Apr 28, 2023

So I took a look at both keyless.md and overview.md

Keyless section explains in detail about the keyless sign-in, while overview.md gives a complete overview of all the methods to sign in.

So I forked the repo and added over 60 lines, from keyless.md, starting from the headline this page talks in detail about keyless sign-in and moved it to overview.md--> the whole keyless signing section (can't even tag the code too, as it is a markdown file*
image
(something like this ^ not the complete code snippet attached here)

Not opening a pull request yet cause I want to discuss if you are working on something and your ideas about it?

Thanks

@haydentherapper
Copy link
Contributor

@Bhardwaj-Himanshu, this issue is already being worked on by Jon. See the open PR #156

@Bhardwaj-Himanshu
Copy link

Bhardwaj-Himanshu commented Apr 29, 2023

Thanks for letting me know @haydentherapper
I'll move to #156 if I could provide any help on the issue.
Also, send me some of your songs if you do rap-->looking at your username;)
Joke intended, no offense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants