Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare the Rekor entry body to the artifact #177

Open
haydentherapper opened this issue May 16, 2024 · 2 comments
Open

Compare the Rekor entry body to the artifact #177

haydentherapper opened this issue May 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Tracking bug for https://github.com/sigstore/sigstore-go/blob/main/pkg/verify/tlog.go#L174

This is not absolutely necessary because we do already compare against the signature which should effectively bind the entry to the artifact.

@haydentherapper haydentherapper added the enhancement New feature or request label May 16, 2024
@cmurphy
Copy link
Contributor

cmurphy commented Jun 24, 2024

This is not absolutely necessary

Was there any more discussion on whether this is worth moving forward with?

I don't think cosign does this, from what I've been able to tell.

@haydentherapper
Copy link
Contributor Author

IIRC yea, Cosign does not check this as well, it only compares signatures - https://github.com/sigstore/cosign/blob/main/pkg/cosign/verify.go#L1164-L1188

Signatures are malleable, for example an ECDSA signature can be represented in two ways, so a signature should not be considered unique. In this example though, that doesn't present an issue from what I can tell, if anything malleability would cause a comparison failure.

@woodruffw Did you have any thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants