Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error initializing SignedEntityVerifier using WithSignedCertificateTimestamps option #83

Closed
malancas opened this issue Jan 26, 2024 · 2 comments · Fixed by #84
Closed
Labels
bug Something isn't working

Comments

@malancas
Copy link
Collaborator

malancas commented Jan 26, 2024

Description

I received the following error message while initializing a SignedEntityVerifier to use with the Public Good instance: "when initializing a new SignedEntityVerifier, you must specify at least one of WithObserverTimestamps(), WithSignedTimestamps(), WithIntegratedTimestamps(), or WithoutAnyObserverTimestampsInsecure()".

The example in the verify doc uses the verify.WithSignedCertificateTimestamps option when initializing a new SignedEntityVerifier for use with Public Good. I tried using this option with verify.NewSignedEntityVerifier but I get the same error. Reading through the verifier code, it looks like the code does not check for this option when validating options used with NewSignedEntityVerifier. Should I be using a different option?

Version

v0.1.0

@malancas malancas added the bug Something isn't working label Jan 26, 2024
@haydentherapper
Copy link
Contributor

Ah, the example doc needs to be updated. WithTransparencyLog is no longer sufficient to fetch a timestamp, because we split out log verification from timestamp verification. You can add WithObserverTimestamp to verify a timestamp from either the log or TSA, WithSignedTimestamps for just the TSA, WithIntegratedTimestamps for just the log, or WithoutAnyObserverTimestampsInsecure if you don't need a timestamp.

@malancas
Copy link
Collaborator Author

Great, I'll update my code accordingly, thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants