Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hoefler & Co test texts from https://github.com/hoeflerco/proofs #15

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simoncozens
Copy link
Member

Closes #14

@simoncozens simoncozens marked this pull request as draft May 19, 2020 16:31
@simoncozens
Copy link
Member Author

Hold fire - I'm going to see if there's a better way to track the hoefler repo than just pulling in the text as a once-off.

@alerque
Copy link
Member

alerque commented May 19, 2020

Why is the Lua file here marked as a binary?

I this a usecase for a git subtree? I haven't looked at how the original is updated or maintained...

@DavidLRowe
Copy link

When I look at the .lua file with Notepad++, it shows NUL characters on lines 6 and 7 just before the close quote. Those may or may not cause a problem, but they probably should be removed and that might make GitHub happy as well.

@jvgaultney
Copy link
Contributor

jvgaultney commented May 20, 2020

No subtrees please - they are just a pain and certainly not worth the bother in this case. I'd prefer a simple incorporation of the appropriate text data and his CC4 license.

@simoncozens
Copy link
Member Author

@jvgaultney
Copy link
Contributor

Hold on - I've now noticed that he's used cc-by-nc-sa, which means we can't use it. I've seen his thread on this, but whatever his intent, nc would place a restriction on fontproof. So sorry, can't do unless his drops the nc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hoefler & Co proof texts
4 participants