Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bibliography changes on authors, editors, publishers, dates #2071

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Bibliography changes on authors, editors, publishers, dates #2071

merged 6 commits into from
Aug 23, 2024

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Jun 15, 2024 •
edited

Closes #2052

Features

  • Some files split and reorganized (minimal refactor for now)
  • Support more Bib(La)TeX name fields (author but also editor, shortauthor, shorteditor, translator, holder) and parse/split names earlier (at entry parsing rather than on each use)
  • Partial support for BibLaTeX extended date field (ISO ETDF)
  • Month regularization (support 3-letter short code as BibTeX, but also 1-12 numbers)

Known issue

  • (See also in-code comment in the Chicago-style implementation file.) Date formatting obeys English only (as "Month Day, Year" with the month in English). This is still better that the previous behavior (raw as-is value of the BibTeX field), but obviously not general.

With the ongoing effort on CSL support, the above know issue might be acceptable for now and not worth addressing. The underlying question, however, is whether we want to consider still supporting the "legacy" style logic; and if so, how much efforts we are ready to involve in it...

@Omikhleia Omikhleia requested a review from alerque as a code owner June 15, 2024 16:55
@Omikhleia Omikhleia marked this pull request as draft June 15, 2024 16:55
@Omikhleia Omikhleia changed the title Bibliography refactor on authors, editors, publishers, dates Bibliography changes on authors, editors, publishers, dates Jun 15, 2024
@Omikhleia Omikhleia mentioned this pull request Jun 15, 2024
Open
@alerque alerque modified the milestones: v0.15.x, v0.15.5 Jun 27, 2024
@Omikhleia
refactor(packages): Split bibtex support code and parse author earlier
af5d928 
Move name parsing functions borrowed from nbibtex and biblatex
compatibility rules to a "support" subfolder.
Split and parse author names earlier (at entry consolidation,
rather than each time a citation is produced).
@Omikhleia Omikhleia force-pushed the bibliography-author-refactor branch from d274a06 to 3ef0109 Compare June 28, 2024 17:49
@Omikhleia Omikhleia mentioned this pull request Jun 29, 2024
Draft
5 tasks
@Omikhleia Omikhleia force-pushed the bibliography-author-refactor branch from 3ef0109 to 74b2fa7 Compare July 14, 2024 08:31
@Omikhleia Omikhleia self-assigned this Jul 14, 2024
@Omikhleia Omikhleia added bug Software bug issue enhancement Software improvement or feature request labels Jul 14, 2024
@Omikhleia Omikhleia marked this pull request as ready for review July 14, 2024 08:46
@alerque
Copy link
Member

alerque commented Aug 23, 2024 •
edited

Rebased commits have only been modified by filtering the Lua through stylua to normalize formatting, no other changes. (For branches like this this has to be done starting at the last commit and working backwards to the first so the style changes get set where they were made without introducing conflicts with later commits that haven't been restyled yet.)

@alerque alerque merged commit e6f9735 into sile-typesetter:master Aug 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees

@Omikhleia Omikhleia

Labels
bug Software bug issue enhancement Software improvement or feature request
Projects
Bibliography cleanup
Status: Done
Milestone
v0.15.5
Development

Successfully merging this pull request may close these issues.

Editor and translator names in bibliography are passed as raw text
2 participants
@Omikhleia @alerque