Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Styling for api links contains backticks #253

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 8, 2023

Issue https://github.com/silverstripeltd/product-issues/issues/627

Ideally would have been done in ss-docs.scss, though I ran into multiple issues when running yarn build

Changes the underline color to grey to match

image

@emteknetnz emteknetnz force-pushed the pulls/master/code-links branch from 29a2274 to 3c48b1a Compare February 8, 2023 01:22
@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 8, 2023

This can happen after the beta I think - it won't materially change anything and we really need to get this out.

In any case as discussed this solution won't work - we need to instead recolour a code (i.e. code blocks inside links) to be more similar to the underline provided by the link itself.

We should also do this in scss - if you're having a problem building it we should fix that. There's no rush on this, it's a subjective visual change with no direct material bearing on the actual documentation itself.

While we're doing this it might be nice to make code a (a link inside a <code> tag) look the same as a code (a <code> tag inside a link)

@GuySartorelli GuySartorelli marked this pull request as draft December 10, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants