Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Replace sass-lint with stylelint #1731

Merged

Conversation

sabina-talipova
Copy link
Contributor

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module still has an old sasslint config file, and is missing the new stylelint config file.

@sabina-talipova
Copy link
Contributor Author

This module still has an old sasslint config file, and is missing the new stylelint config file.

Oh sorry, @GuySartorelli, I must mention, that you already merged main changes, the new stylelint config file and changes in package.json already exist. I just updated package.json with new versions of js modules.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yup, I was looking at the wrong branch.
LGTM

@GuySartorelli GuySartorelli merged commit 3bf5a60 into silverstripe:2.2 Apr 28, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.2/stylelint branch April 28, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants