Merge pull request #374 from creative-commoners/pulls/3/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 982f094 · 982f094
2 parents aac7023 + 86c1aa2
commit 982f094
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Controllers/HistoryViewerController.php b/src/Controllers/HistoryViewerController.php
@@ -355,7 +355,7 @@ public function getCompareForm(array $context)
         return $form;
     }
 
-    public function versionForm(HTTPRequest $request = null)
+    public function versionForm(?HTTPRequest $request = null)
     {
         if (!$request) {
             $this->jsonError(400);
@@ -373,7 +373,7 @@ public function versionForm(HTTPRequest $request = null)
         }
     }
 
-    public function compareForm(HTTPRequest $request = null)
+    public function compareForm(?HTTPRequest $request = null)
     {
         if (!$request) {
             $this->jsonError(400);

diff --git a/src/Forms/DataObjectVersionFormFactory.php b/src/Forms/DataObjectVersionFormFactory.php
@@ -38,7 +38,7 @@ class DataObjectVersionFormFactory implements FormFactory
         DataObjectVersionFormFactory::TYPE_HISTORY,
     ];
 
-    public function getForm(RequestHandler $controller = null, $name = FormFactory::DEFAULT_NAME, $context = [])
+    public function getForm(?RequestHandler $controller = null, $name = FormFactory::DEFAULT_NAME, $context = [])
     {
         // Validate context
         foreach ($this->getRequiredContext() as $required) {
@@ -91,7 +91,7 @@ public function isReadonlyFormType(array $context)
         return in_array($this->getFormType($context), $this->config()->get('readonly_types') ?? []);
     }
 
-    protected function getFormFields(RequestHandler $controller = null, $name, $context = [])
+    protected function getFormFields(?RequestHandler $controller, $name, $context = [])
     {
         $record = $context['Record'];
         /** @var FieldList $fields */
@@ -157,7 +157,7 @@ protected function removeSelectedRightTitles(FieldList $fields)
         }
     }
 
-    protected function getFormActions(RequestHandler $controller = null, $formName, $context = [])
+    protected function getFormActions(?RequestHandler $controller, $formName, $context = [])
     {
         $actions = FieldList::create();
         $this->invokeWithExtensions('updateFormActions', $actions, $controller, $formName, $context);