Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RelationDiffer with RelationList callbacks #44

Open
unclecheese opened this issue Apr 20, 2021 · 0 comments
Open

Replace RelationDiffer with RelationList callbacks #44

unclecheese opened this issue Apr 20, 2021 · 0 comments

Comments

@unclecheese
Copy link

The RelationDiffer class is a really heavy-handed solution for ensuring snapshots are created when a many many changes on a page (e.g. adding / removing categories in a checkboxsetfield). Additionally, this class is used to navigate the anomaly of page saves resulting in elemental editor saves.

Now that we have callbacks for add/remove on relation lists, maybe this is a more elegant solution and we can deprecate RelationDiffer. I have a POC working in the silverstripe-gatsby module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant