Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't use deprecated usage of get_class() #103

Merged
merged 1 commit into from
Mar 19, 2024
Merged

FIX Don't use deprecated usage of get_class() #103

merged 1 commit into from
Mar 19, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli changed the base branch from 3 to 3.2 March 19, 2024 23:06
@GuySartorelli GuySartorelli mentioned this pull request Mar 19, 2024
Closed
emteknetnz
emteknetnz approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have double checked that self::class is correct, not static::class

@emteknetnz emteknetnz merged commit 49cc581 into silverstripe:3.2 Mar 19, 2024
9 checks passed
@emteknetnz emteknetnz deleted the pulls/3.2/no-deprecated-getclass branch March 19, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz