Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare: Few improvements #3944

Merged
merged 8 commits into from
Nov 27, 2023
Merged

compare: Few improvements #3944

merged 8 commits into from
Nov 27, 2023

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Oct 2, 2023 •
edited
Loading

This PR rework a bit silx compare to fix some problems related to RGB images.

Now it supports at least Y,X,RGB using uint8. Other encodage are not properly supported.

  • fabio is not reading images as RGB, now PIL is used for few file extensons (jpg, png) (for convenience, that's not our main use case anyway)
  • The DnD was not working, maybe the implementation depends on PyQt binding version, now the implementation is stronger
  • Save/restore y axis orientation
  • Added some HDF5 autogenerated samples for images (intensity, RGBA)
  • Plus few fixes and typo

image
image

Changelog:

  • Added silx compare support of uint8 dataset as Y,X,RGB layout

@vallsv vallsv requested a review from t20100 October 2, 2023 08:04
@vallsv vallsv self-assigned this Oct 2, 2023
@vallsv vallsv mentioned this pull request Oct 2, 2023
Merged
@vallsv
Copy link
Contributor Author

vallsv commented Oct 2, 2023

This PR was fixed, it's ok to be reviewed.

@vallsv vallsv changed the title compare: fix typo compare: Few improvements Oct 2, 2023
t20100
t20100 approved these changes Oct 23, 2023
View reviewed changes
src/silx/app/compare/CompareImagesWindow.py Outdated Show resolved Hide resolved
src/silx/app/compare/CompareImagesWindow.py Show resolved Hide resolved
@t20100 t20100 added this to the 2.0.0 milestone Oct 23, 2023
@vallsv @t20100
Update src/silx/app/compare/CompareImagesWindow.py
c1fb910 
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
@t20100 t20100 merged commit 32716b4 into silx-kit:main Nov 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 approved these changes

Assignees

@vallsv vallsv

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vallsv @t20100