Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.util.retry: Fixed resetting the timeout timer when iterating #4157

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

woutdenolf
Copy link
Contributor

This fix warrants a silx release. It affects all online workflows using blissdata.

@woutdenolf woutdenolf requested a review from payno August 12, 2024 14:32
src/silx/utils/retry.py Outdated Show resolved Hide resolved
src/silx/utils/retry.py Outdated Show resolved Hide resolved
src/silx/utils/retry.py Outdated Show resolved Hide resolved
@woutdenolf woutdenolf force-pushed the fix_retry_reset_on_iteration branch 6 times, most recently from 6758978 to 6de60c8 Compare August 12, 2024 16:36
@woutdenolf
Copy link
Contributor Author

woutdenolf commented Aug 12, 2024

@t20100 @loichuder Fix for workflows that decide the scan ended while this is not true.

What happens is that the retry_timeout is reached (optional way to stop the data iteration in addition to the end_time presence). And it is reached because the timer did not get reset whenever data was yielded. Which means the timeout applied to the entire data processing instead of just the time it takes to get any new data. FYI the time it takes for a lima file to be completed is the time-limiting operation.

@woutdenolf woutdenolf merged commit 5a8cae6 into silx-kit:main Aug 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants