Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor marke events logic #72

Open
kaplanelad opened this issue Feb 16, 2020 · 0 comments
Open

Refactor marke events logic #72

kaplanelad opened this issue Feb 16, 2020 · 0 comments
Labels
component-api enhancement New feature or request good first issue Good for newcomers

Comments

@kaplanelad
Copy link
Contributor

kaplanelad commented Feb 16, 2020

Description:
StatusBay event flow:

  1. The watcher collect events from multiple resources (pods, deployment, replicaset, daemonset and etc)
  2. All the events saved in DB
  3. The frontend makes a request to get a deployment detail (api/v1/kubernetes/application/{apply_id})
  4. The API get the row from the DB, and loop on all the resources kind for check the event content (for marke suspects events )
    File: api/kubernetes/markevent.go
    Function: MarkApplicationDeploymentEvents

Problem:
The current implementation is not generic enough when we add more resources kind's we need to modify this function + we have a reputable code.

Definition Of Done:
Support automatically multiple resources kind that added into StatysBay
Move reputable code to function

@kaplanelad kaplanelad added component-api enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-api enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant