Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast slider has no effect #82

Closed
adrianghc opened this issue Apr 30, 2022 · 3 comments
Closed

Contrast slider has no effect #82

adrianghc opened this issue Apr 30, 2022 · 3 comments
Assignees
Labels
being worked on Somebody is looking into this bug Something isn't working

Comments

@adrianghc
Copy link

adrianghc commented Apr 30, 2022

Describe the bug
Sometime in the past few weeks maybe, the contrast slider has stopped working. I wonder if this might be related to the workaround you implemented for #48?

To Reproduce

  1. Enable advanced scan settings.
  2. Scan a page.
  3. Change the contrast setting with the slider and scan the page again.

Expected behavior
There should be a noticeable change in contrast between the two scans.

Log data
log20220430.txt
Looking at the log data, it seems that contrast is always either 0 or null, regardless of the value that I set through the slider.

@adrianghc adrianghc added the bug Something isn't working label Apr 30, 2022
@simon-knuth
Copy link
Owner

Yes you're right, there is an unintended connection between the brightness and contrast values. The contrast is in most cases being ignored if the brightness is set to its default value (usually 0).

I believe I'll push out a small update prior to the next release to get this fixed over coming days.

@simon-knuth simon-knuth added the being worked on Somebody is looking into this label May 7, 2022
@simon-knuth
Copy link
Owner

Should be fixed in v3.1.3 - thank you for reporting this!

@adrianghc
Copy link
Author

And so it is. Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
being worked on Somebody is looking into this bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants