Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect report on glow/trainer.py #25

Open
kelvinqin opened this issue Jan 13, 2021 · 0 comments
Open

Defect report on glow/trainer.py #25

kelvinqin opened this issue Jan 13, 2021 · 0 comments

Comments

@kelvinqin
Copy link

Simon,
I am thinking the following code of trainer.py may have a problem ---

        print(
            f'Loss: {loss.item():.5f}/ Validation Loss: {loss_val:.5f} '
        )

Here loss's value was updated per batch (it was not accumulated per batch), so here I guess the attention is to print out an average loss of the total train set, but it actually print out the loss of the last batch of each epoch,

Please let me know your thoughts, maybe I am wrong?

Have a nice day,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant