Volar packages renamed

[tobiasdiez]

The volar packages have been renamed in vuejs/language-tools#3134. It would be nice if the new vue/typescript package could be supported as well.

[simonhaenisch]

I haven't followed up at all with the changes in Volar. Just tried and there seem to be breaking changes at least to the exported types, e.g. I was using

import('@volar/vue-language-core/out/types').LanguageServiceHost

in @volar/vue-typescript version 1.0.9 but that type doesn't exist anymore in the latest version (or the renamed package).

Some help with this issue would be highly appreciated.

[tobiasdiez]

Yes, this interface has been removed: https://github.com/vuejs/language-tools/blob/a73e249f6b5638e7029c0c929eb704e2230a5af3/CHANGELOG.md?plain=1#L157
createLanguageService now creates the language host itself and has a different method signature too: https://github.com/vuejs/language-tools/blob/a73e249f6b5638e7029c0c929eb704e2230a5af3/packages/vue-typescript/src/index.ts#L7-L11

[simonhaenisch]

Yup that's where I got stuck actually, cause it said sth like "requires 4 arguments but only provided 1" and I didn't really have time to figure out what to pass there.

Looking at the interface again now it looks like instead of a getVueCompilerOptions method on the host, you pass them separately when creating the language service. Maybe I'll have some time for this soon, but it'll require a breaking change on my side from what i can tell (not sure why the language-tools didn't have a major bump).

[Shinigami92]

@johnsoncodehk Help!

[johnsoncodehk]

I think we don't need to support the new @vue/typescript, we are planning to deprecate it in 2.0. Keep using @volar/vue-typescript 1.6 would be fine for now.

On the other hand, @volar/typescript (the base package of @vue/typescript) now has a decorateLanguageService() API, which can add Vue support to the existing TS language service instance instead of using createLanguageService() to create a new one. decorateLanguageService() was originally a 2.0 API, but it has been released early. We can check how to integrate decorateLanguageService() in this repo after 2.0 if needed.

[Shinigami92]

@johnsoncodehk Now Vue 3.4 came out and it looks like @volar/typescript v1.6.5 is missing support for defineModel. So I cant upgrade to @vue/typescript v1.8.0 due to be stuck with prettier-plugin-organize-imports

Does your previous statement with 2.0 still count? What is the progress-state?
Can I workaround it for now somehow? Or can I not use the newest Vue features anymore, because I'm stuck in dependencies?

---

Edit:

I just saw that it is "just" an eslint error 🤔 👀
Maybe I can add that in my eslintrc for now, to suppress the error

---

Edit 2:

My issue will be fixed via: vuejs/eslint-plugin-vue#2130
so nevermind 🙂

[Shinigami92]

With Volar v2.0, is this the day we can expect new support for it?

[simonhaenisch]

I don't work with Vue/Volar at all, so if someone could update me about the current state and ideas how to support it, I'm all ears (:

[so1ve]

@simonhaenisch What do you need? :)

[simonhaenisch]

Details about how to technically do this with Volar 2:

prettier-plugin-organize-imports/lib/get-language-service.js

Line 14 in 9609e4e

return require('@volar/vue-typescript').createLanguageService(getVueLanguageServiceHost(filepath, code));

prettier-plugin-organize-imports/lib/service-host.js

Lines 49 to 65 in 9609e4e

	function getVueLanguageServiceHost(path, content) {
	const tsconfig = findTsconfig(path);
	const vueCompilerOptions = getVueCompilerOptions(tsconfig);
	return {
	...getTypeScriptLanguageServiceHost(path, content),
	getVueCompilationSettings: () => vueCompilerOptions,
	/**
	* Can return either `require('typescript')` or `require('typescript/lib/tsserverlibrary')`.
	*
	* @see https://github.com/simonhaenisch/prettier-plugin-organize-imports/pull/60#discussion_r934408179
	*
	* @returns {any}
	*/
	getTypeScriptModule: () => ts,
	};
	}

[so1ve]

Ok I'll look into this soon

[arkandias]

Hi guys, can't do much to help here, just to let you know that your work fixing this issue is greatly appreciated!

[mreduar]

Does anyone know of an alternative that works with the latest vue updates?

[ddzy]

Guys, any solutions?

[mreduar]

Guys, any solutions?

I removed @volar/vue-typescript and @vue/typescript, and it started working fine.

Also as @johnsoncodehk said at vuejs/language-tools#3402

@vue/typescript is an over-encapsulation, we can use @volar/typescript directly.

Besides it is already deprecated in V2. Installing @volar/typescript also works fine.

[Shinigami92]

I wont like to depend on deprecated packages, cause I wont get updated then with new features related to the replacement of the deprecated package.
Also there is also the VSCode extension that relies on the vue and typescript language servers and I don't want to either have multiple language servers running resulting in potential conflicts nor I wont like to be unable to benefit from newest extension feature relying of new dependencies.

If a package is marked as deprecated, there is a reason for that and it should be worked on.
If @simonhaenisch does not have the time and capacity, maybe there should be an additional maintainer with approval, merge and publish rights, so we can move forward.

[johnsoncodehk]

This is a PR to migrate to @volar/typescript+@vue/language-core: #129

[simonhaenisch]

Published as 4.0.0 🎉

Please try it out and let me know if there are any issues 🙏

[mreduar]

Published as 4.0.0 🎉

Please try it out and let me know if there are any issues 🙏

For now it works well with vue-tsc