You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The README seems indicates that this should be compatible with k8s.io/klog/v2. However, when I attempt to substitute this in go.mod, I see:
vendor/istio.io/pkg/log/config.go:418:32: cannot use NewLogrAdapter(KlogScope) (type logr.Logger) as type "github.com/go-kit/kit/log".Logger in argument to klog.SetLogger:
logr.Logger does not implement "github.com/go-kit/kit/log".Logger (missing Log method)
Removing the require override from go.mod causes the builder failure to go away.
The text was updated successfully, but these errors were encountered:
brian-avery
changed the title
2.1.0 doesn't seem to be compatible with k8s.io/klog/v2
Issues using simonpasquier/klog-gokit 2.1.0 with k8s.io/klog/v2
Aug 6, 2021
github.com/go-kit/log requires implementation of this interface:
type Logger interface {
Log(keyvals ...interface{}) error
}
which github.com/go-logr/logr does not implement. This causes issues when using dependencies that expect klog, but have it replaced with klog-gokit
The README seems indicates that this should be compatible with
k8s.io/klog/v2
. However, when I attempt to substitute this ingo.mod
, I see:Removing the require override from go.mod causes the builder failure to go away.
The text was updated successfully, but these errors were encountered: