Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with new size_limit config - it's not being picked up #3

Closed
simonw opened this issue Jul 27, 2020 · 1 comment
Closed

Bug with new size_limit config - it's not being picked up #3

simonw opened this issue Jul 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Jul 27, 2020

When you install the plugin it doesn't pick up the size_limit setting.
@simonw simonw added the bug Something isn't working label Jul 27, 2020
@simonw
Copy link
Owner Author

simonw commented Jul 27, 2020

Turns out it's because of the default None parameter here:

datasette-render-images/datasette_render_images.py

Lines 9 to 10 in d876626

@hookimpl
def render_cell(value, datasette=None):

It must be messing with pluggy somehow.

@simonw simonw closed this as completed in 52b40c3 Jul 27, 2020
simonw added a commit that referenced this issue Jul 27, 2020
@simonw
Release 0.3.1
20f05e9 
Refs #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw