Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently Creates a new port instead of renaming the old one. #1

Open
simotek opened this issue Aug 26, 2023 · 1 comment
Open

Currently Creates a new port instead of renaming the old one. #1

simotek opened this issue Aug 26, 2023 · 1 comment

Comments

@simotek
Copy link
Owner

simotek commented Aug 26, 2023

I spent a lot of time trying to get port renaming working, but I couldn't figure it out on my setup. Given that I don't rename ports after i've patched them in jack this is not a big enough issue for me to spend more time fixing at the moment.

@nodens
Copy link

nodens commented Feb 16, 2024

I'm not a coder, so please bear with me if I'm completely off, but looking at the code, it looks like you allocate 256 for the port name, but the max (short) port name size should be jack_port_name_size() - <client name length> - 1 (for the null char at the end) ? And looking at jack defines jack_port_name_size() is usually 256.

Again, sorry if that's completely off, C++ isn't my forte at all and I possibly don't get at all what I'm reading, I'd just really like to be able to rename ports as it works better for my workflow 😅

Anyway, let me take the opportunity to thank you for reviving this useful module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants