Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit - "vulnerable versions of elliptic" #303

Closed
endel opened this issue Aug 6, 2024 · 2 comments
Closed

npm audit - "vulnerable versions of elliptic" #303

endel opened this issue Aug 6, 2024 · 2 comments

Comments

@endel
Copy link
Contributor

endel commented Aug 6, 2024

Hi there 👋

The npm audit is saying grant is vulnerable because of Brightspace/node-jwk-to-pem#187

Comments on the jwk-to-pem thread are saying Node.js now supports that same functionality natively now, so maybe jwk-to-pem dependency could be entirely removed now?

Cheers!


# npm audit report

elliptic  >=2.0.0
Elliptic allows BER-encoded signatures - https://github.com/advisories/GHSA-49q7-c7j4-3p7m
Elliptic's ECDSA missing check for whether leading bit of r and s is zero - https://github.com/advisories/GHSA-977x-g7h5-7qgw
Elliptic's EDDSA missing signature length check - https://github.com/advisories/GHSA-f7q4-pwc6-w24p
fix available via `npm audit fix --force`
Will install colyseus@0.15.13, which is a breaking change
node_modules/elliptic
  jwk-to-pem  >=1.2.1
  Depends on vulnerable versions of elliptic
  node_modules/jwk-to-pem
    grant  >=5.1.0
    Depends on vulnerable versions of jwk-to-pem
@simov
Copy link
Owner

simov commented Aug 6, 2024

Thanks for reporting this, I will have a look.

Note that this dependency is only being used when you have configured your client (provider) in Grant to authenticate with token_endpoint_auth_method=private_key_jwt, if your provider supports that in the first place.

@simov
Copy link
Owner

simov commented Aug 14, 2024

I was planning to release a patch, but it just got fixed here indutny/elliptic#317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants