1.2.4 breaks webpack compilation

[neonerd]

Module '"D:/xxx/node_modules/slugify/index"' resolves to a non-module entity and cannot be imported using this construct.

[neonerd]

Can be fixed by turning

import * as slugify from "slugify"

to

import  slugify from "slugify"

But this is still a breaking change for people using ES6 import notation and should've therefore been projected in the semver as 2.0.0.

[simov]

How can I reproduce this issue? The only thing added in 1.2.4 is the index.d.ts file.

[neonerd]

I'm not sure whether it was 1.2.4 or something before, the last working version was 1.2.1 for me.

I'll try to attach a reproducable setup tomorrow. :)

[zucher]

The Project https://github.com/Rebilly/ReDoc get the same error during "npm run build-dist"

[simov]

Like I said earlier the only thing changed was the TypeScript definition: https://github.com/simov/slugify/blob/master/index.d.ts
Can you spot any issues with that file?

[jestho]

My guess would be that export = slugify should probably be export default slugify. That or export declare function slugify(…)

[simov]

Thanks @jestho! However I'm not that familiar with TypeScript. If anyone can test and see which one of the suggested syntax changes fixes the issue I'll add/merge it.

[neonerd]

You have a pull request fixing this, tested with newest Webpack / TS-Loader example.

Works both with

import slugify from "slugify"

and

import * as slugify from "slugify"

now.

[simov]

Everyone, the TypeScript definition was fixed in v1.2.6 ! 🎉 ✨

Thank you! 👍