Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bulgarian locale. #136

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Add Bulgarian locale. #136

merged 2 commits into from
Nov 6, 2021

Conversation

haltsir
Copy link
Contributor

@haltsir haltsir commented Oct 31, 2021

Ths PR adds support for Bulgarian transliteration. The rules are copied from the official Bulgarian Transliteration Law.

One exception that might occur, but afaik is not supported in the library, is changing the final two letters to 'ia' instead of 'iya' when the word ends in 'ия' (e.g. Мизия should be transliterated to Mizia instead of Miziya). A second exception is that the official country name is always transliterated to "Bulgaria" instead of "Balgariya". The third exception is that the currency "лв." should be transliterated to "leva". If the library could somehow support words as well, then two of the three exceptions would be resolved. For the first exception it's needed to check the end of the words only.

@simov
Copy link
Owner

simov commented Nov 6, 2021

Thanks for contributing, all good points. I don't think that we will be able to resolve those edge cases right now, even though they seem quite severe IMO.

I'm fine with updating those alphabet letters as they seem correct to me, however, I'm thinking that all other special characters should be removed in general, probably in next major or something like that. The reason why is that this only inflates the library size (for browsers that matter) without any real benefit. Users can extend the library and add those if needed.

@haltsir
Copy link
Contributor Author

haltsir commented Nov 6, 2021

I understand, do you want me to remove them now or would you that when you do it for every transliteration?

@simov
Copy link
Owner

simov commented Nov 6, 2021

I'd prefer to have them removed now, I know we have them for other locales, but this just keeps inflating the library size and eventually I'd like to remove them for all.

@simov simov merged commit 13041ae into simov:master Nov 6, 2021
@simov
Copy link
Owner

simov commented Nov 6, 2021

Thanks 👍

@haltsir haltsir deleted the bulgarian-locale branch November 6, 2021 15:35
@simov
Copy link
Owner

simov commented Nov 7, 2021

Published in v1.6.2

@haltsir
Copy link
Contributor Author

haltsir commented Nov 8, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants