Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferFunctionHeader should take Station, Channel objects #41

Closed
kkappler opened this issue Jul 20, 2021 · 2 comments
Closed

TransferFunctionHeader should take Station, Channel objects #41

kkappler opened this issue Jul 20, 2021 · 2 comments

Comments

@kkappler
Copy link
Collaborator

Currently this is just using some id strings like "PKD" and "ex", "ey" to denote info about the processing channels.

However, information about the instrument locations and orientations must eventually be passed on to the output data structure. To do this we will need to carry along the mt_metadata objects.

@kkappler
Copy link
Collaborator Author

In the longer-term we want the full metadata objects stored in the header. In the shorter term for testing we can have been using string ids. A good way to manage the transition is to leave a placeholder for the metadata objects and the ids. The id methods can later be overwritten by properties that access the metadata.

For example, local_station can be objects of type mt_metadata.transfer_functions.tf.station.Station() or None
Then local_station_id can return self.local_station.id if it is available, but otherwise return
self._local_station_id.

@kkappler
Copy link
Collaborator Author

kkappler commented Oct 2, 2021

This has been solved by the TF class from mt_metadata. Also TransferFunctionHeader will be deprecated rather than improved (see issue #109 )

@kkappler kkappler closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant