Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency Bands Class to support non-contiguous intervals #47

Closed
kkappler opened this issue Jul 22, 2021 · 3 comments
Closed

Frequency Bands Class to support non-contiguous intervals #47

kkappler opened this issue Jul 22, 2021 · 3 comments
Labels
side quest Not critical to program function but a potential place to get lost, maybe in a good way

Comments

@kkappler
Copy link
Collaborator

Not high priority
FrequencyBands are currently specified by a lower_bound and an upper_bound. This handles most cases but it is not unrealistic that we may encounter bands which have a few contaminated harmonics and we would like to suppress these. There is currently no method for handling this.

Of course we could split a given band into a sequence of contiguous sub-bands, but in that case we have fewer observations to input to robust regression. This could compromise the quality of some estimates.

It would be nice if a FrequencyBand object could specify some harmonics to ignore.

This of course breaks compatibility with EMTF z-files but those are slated for deprecation in the long term anyhow

@kkappler kkappler added the side quest Not critical to program function but a potential place to get lost, maybe in a good way label Oct 6, 2021
@kkappler
Copy link
Collaborator Author

kkappler commented Oct 6, 2021

This maybe more more trouble to implement than it's worth. Needs review and prioritization, and if we address it, it needs definition of use cases.

Also, this actually depends on issue #150 being fixed first, since currently, EMTF band setup is still baked into aurora.

@kkappler
Copy link
Collaborator Author

kkappler commented Sep 10, 2022

When reviewing this, also consider:

  • Add band_edge_definition = ["exact", "canonical"] to config
  • Definition of some bands templates that people can use
  • logarithmic spaced band templates

@kkappler
Copy link
Collaborator Author

This would be better handled by using masks in weighting functions (#61). Marking this as closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
side quest Not critical to program function but a potential place to get lost, maybe in a good way
Projects
None yet
Development

No branches or pull requests

1 participant