Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull requests directly onto dev #78

Closed
5 tasks done
lheagy opened this issue Nov 13, 2017 · 2 comments
Closed
5 tasks done

pull requests directly onto dev #78

lheagy opened this issue Nov 13, 2017 · 2 comments

Comments

@lheagy
Copy link
Member

lheagy commented Nov 13, 2017

Similar to simpeg/simpeg#651: To speed up getting features live into discretize, we could do pull requests directly onto master.

Impacts

  • your features are rapidly live to the world!
  • pull requests should be small and focussed
  • pull request notes will be used as the release notes and so should contain sufficient detail to describe the changes, any breaks in backwards compatibility, etc.

TODO's

  • switch main branch to master on github
  • ensure dev and master synced
  • change base of current pr's onto dev to master
  • delete dev branch
  • update travis to remove deployment sequence from dev

Timeline

We can do this as soon as #73 is in. Are there any concerns about doing this soon? cc @rowanc1, @grosenkj, @sgkang, @thast, @fourndo. Can you please give a 👍 or 👎?

@lheagy
Copy link
Member Author

lheagy commented Dec 5, 2017

closed with #79

@lheagy lheagy closed this as completed Dec 16, 2017
@leouieda
Copy link
Member

leouieda commented Dec 17, 2017

Hi all, just a comment regarding the "release notes from PR" and "small PRs". I've been doing these in conjunction with squash merges for PRs and I like it a lot. When I merge the PR, github will squash all commits down to a single one and allows you to edit the commit message. I copy and edit the initial PR description as the message. This gets rid of trial-and-error commits in the PR or commits that result in broken tests. It also allows me to edit bad messages from newer users (or my own). It also gives a bit of freedom when I just want to commit half finished work and don't have the time for a long good message. Another advantage is that all commits in master pass the tests and work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants