-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a hasPseudoElementStyle
assertion
#232
Implement a hasPseudoElementStyle
assertion
#232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @joankaradimov! this looks awesome already, just one minor thing left to do :)
Thanks!
I've committed the suggested change. Just let me know if everything else looks good so that I squash the commits. |
It turns out the initial overload signature for Also there seemed to be some code which did not have a documentation generated for it. I've committed that separately. Finally - there are some DOS new lines mixed with the Unix new lines in the examples in API.md. This appears to be the case for the existing examples too. There are no DOS new lines in the docstrings. Should I log a bug for that? |
Interesting. That sounds like a bug (or maybe even feature 🤔) in |
@joankaradimov the problem with |
Ah, ok. I was thinking of something different.
I see you made this private and removed the commit. I'm going to squash the rest of it and force push. |
thanks again 🙏 |
Thank you for the help and the quick responses. And also for quickly releasing this! |
Resolves #229