Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow calling assert.dom() with no argument defaulting to rootElement #60

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Allow calling assert.dom() with no argument defaulting to rootElement #60

merged 1 commit into from
Mar 12, 2018

Conversation

lennyburdette
Copy link
Contributor

@lennyburdette lennyburdette commented Mar 12, 2018 •
edited by Turbo87
Loading

Resolves #57

cc @spencer516

Turbo87
Turbo87 approved these changes Mar 12, 2018
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! thanks a lot! 👍

@Turbo87 Turbo87 changed the title ENHANCEMENT assert.dom() with no argument defaults to rootElement assert.dom() with no argument defaults to rootElement Mar 12, 2018
@Turbo87 Turbo87 changed the title assert.dom() with no argument defaults to rootElement Allow calling assert.dom() with no argument defaulting to rootElement Mar 12, 2018
@Turbo87 Turbo87 merged commit 4f20c24 into mainmatter:master Mar 12, 2018
Turbo87 added a commit to Turbo87/qunit-dom that referenced this pull request Jul 30, 2020
@Turbo87
Fix assert.dom(null).exists() case
25aae7b 
mainmatter#60 unintentionally broke the above case. This commit fixes the implementation by only defaulting to the `rootElement` as `target` when the user hasn't provided any arguments at all.
@Turbo87 Turbo87 mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lennyburdette @Turbo87