Adding new alias for hasText called matchesText #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Mar 28, 2018
There was a problem hiding this comment.
Thanks for your contribution @RahulShivkumar! 👍
I think since hasText() also accepts regular expressions and those are often checked against using the verb "matches" this fits quite well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasTextis a little confusing and strikes me as an inclusion rather than a strict comparison. I thinkmatchesTextis more explicit in calling that out. I'm assuming the documentation change in API.md should come out after the next release and not with this PR.This is my first open source contribution :) please let me know if there is anything else I'd have to change anywhere else!