-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive typography + line height? #31
Comments
How you'd do this is have Rucksack parse Though I'm not sure what you're trying to achieve. By definition unitless line height is 'responsive'. Are there certain points where you want a different line height unit? How would rucksack know this? |
Yes, I was talking about
That's why I said that unitless line height works fine. But if you want to get artsy with the line height, rucksack can't help you.
By using something like
or
} I guess |
Seems the |
This feature has been added upstream in |
Any chance somebody can update the postcss-responsive-type dependency so we can start using this feature? |
@contra sorry missed this, will bump it now and release a new version |
So, is there a fix or not? I have issue with Firefox - Responsive doesn't work like it should! |
This was released in the linked commit, you can use responsive line heights with new line height declarations |
Would it be a good idea?
Something like:
or
Unitless line height is fine, but if you want to set a specific line height for a specific font range, you have to do it without Rucksack, the result being unnecessary multiple media queries.
I guess it wouldn't work just by adding the line height along font size, since that would result in line heights like 1.4654643?
The text was updated successfully, but these errors were encountered: