Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic links are not followed #231

Open
Zlendy opened this issue May 3, 2024 · 4 comments
Open

Symbolic links are not followed #231

Zlendy opened this issue May 3, 2024 · 4 comments
Assignees

Comments

@Zlendy
Copy link

Zlendy commented May 3, 2024

I attempted to organize a library of pictures using symlinks to directories before importing them into Immich using this tool, only to realize that it treats symlinks as raw files and does not follow them.

image

@simulot
Copy link
Owner

simulot commented May 3, 2024

Good to know. I'll check that issue

@simulot simulot self-assigned this May 4, 2024
@simulot
Copy link
Owner

simulot commented May 4, 2024

Well...
I'm using the standard go library function WalkDir to parse the file system. The document says:

WalkDir does not follow symbolic links found in directories, but if root itself is a symbolic link, its target will be walked.

So this isn't an easy fix. I'll need to refactor the code to handle symlinks properly.

@Zlendy
Copy link
Author

Zlendy commented May 4, 2024

Would it be viable to call the WalkDir function for each symlinked directory?

@simulot
Copy link
Owner

simulot commented May 5, 2024

Surely, another way is to get ride of this function, and walk through the folders with basic functions and handle symlinks as we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants